Scala Scheduler Bindings Fix #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
headinthebox
commented
Feb 5, 2014
headinthebox
commented
- Updated schedulers to reflect 0.17 changes.
- Add timer bindings
- Add timer bindings
|
RxJava-pull-requests #737 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Feb 5, 2014
Scala Scheduler Bindings Fix
| */ | ||
| def apply(): IOScheduler = { | ||
| new IOScheduler(rx.schedulers.Schedulers.computation()) | ||
| } |
There was a problem hiding this comment.
This should be ComputationScheduler I guess ;-)
There was a problem hiding this comment.
Will fix that.
On Thu, Feb 6, 2014 at 11:27 AM, samuelgruetter [email protected]:
In
language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/schedulers/ComputationScheduler.scala:+import rx.lang.scala.Scheduler
+
+
+object ComputationScheduler {
- /**
- * {@link Scheduler} intended for computational work.
- *
- * This can be used for event-loops, processing callbacks and other computational work.
- *
- * Do not perform IO-bound work on this scheduler. Use {@link IOScheduler()} instead.
- * @return { @link Scheduler} for computation-bound work.
- */
- def apply(): IOScheduler = {
- new IOScheduler(rx.schedulers.Schedulers.computation())
- }
This should be ComputationScheduler I guess ;-)
Reply to this email directly or view it on GitHubhttps://github.com//pull/817/files#r9495519
.
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.