Bind pre release #774
Closed
Bind pre release #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new create signature - new bind operator - new subscribe overload - OperationReplay is failing unit tests, all others are passing
- also simplified implementation to not worry about thread-safety as per Rx contract - performance improvement from 4,033,468 ops/sec -> 6,731,287 ops/sec
- even though unit tests don’t see it because of SafeObserver, the Take operator should not emit onCompleted more than once
- it’s working … but I can’t figure out the co/contra-variance for the generics! anyone have ideas?
- Changed `bind` signature to match the variant discussed at #746 (comment) - Updated code to new signature. - Re-implemented GroupBy operator with `bind`
Found bug while doing Parallel. It was completing prematurely when child groups were asynchronous and delayed.
- forgot to add earlier
It had not been successfully migrated before … this now passes unit tests. This is the bridge until we port it to the new “bind” model.
As per discussion at #770 (comment)
… ready to be re-written by @DavidMGross :-)
|
RxJava-pull-requests #689 SUCCESS |
|
Merged into #770 Thanks @headinthebox |
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed scala issue (map with index was removed)