Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Remove toolVersion for jacoco and checkstyle #7261

Conversation

benjamintboyle
Copy link
Contributor

Remove versioning of Jacoco and Checkstyle. Instead they will be updated
by Gradle when it is updated. Dependabot does not update tool versions.
If issues come up, they can be corrected when Gradle is updated.

Remove versioning of Jacoco and Checkstyle. Instead they will be updated
by Gradle when it is updated. Dependabot does not update tool versions.
If issues come up, they can be corrected when Gradle is updated.
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #7261 (68034b3) into 3.x (2f4815d) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7261      +/-   ##
============================================
- Coverage     99.55%   99.51%   -0.05%     
+ Complexity     6759     6756       -3     
============================================
  Files           747      747              
  Lines         47391    47391              
  Branches       6382     6382              
============================================
- Hits          47179    47159      -20     
- Misses           93      105      +12     
- Partials        119      127       +8     
Impacted Files Coverage Δ Complexity Δ
...observable/ObservableWindowSubscribeIntercept.java 87.50% <0.00%> (-12.50%) 4.00% <0.00%> (-1.00%)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 89.90% <0.00%> (-8.26%) 2.00% <0.00%> (ø%)
...l/operators/observable/ObservableFlatMapMaybe.java 92.25% <0.00%> (-4.93%) 2.00% <0.00%> (ø%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 95.33% <0.00%> (-3.11%) 2.00% <0.00%> (ø%)
...ternal/operators/observable/ObservablePublish.java 97.29% <0.00%> (-1.81%) 16.00% <0.00%> (-1.00%)
...internal/operators/flowable/FlowableSwitchMap.java 98.58% <0.00%> (-1.42%) 3.00% <0.00%> (ø%)
...a3/internal/operators/flowable/FlowableReplay.java 98.92% <0.00%> (-0.86%) 21.00% <0.00%> (ø%)
...nternal/operators/observable/ObservableCreate.java 98.29% <0.00%> (-0.86%) 2.00% <0.00%> (ø%)
...va3/internal/operators/flowable/FlowableCache.java 99.24% <0.00%> (-0.76%) 38.00% <0.00%> (-1.00%)
...ternal/operators/observable/ObservableFlatMap.java 98.22% <0.00%> (+0.35%) 3.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4815d...68034b3. Read the comment docs.

@benjamintboyle
Copy link
Contributor Author

Note for Gradle 7.0, the current version is:
Jacoco: 0.8.6
Checkstyle: 8.37

@akarnokd akarnokd added this to the 3.1 milestone May 7, 2021
@akarnokd akarnokd merged commit 177256e into ReactiveX:3.x May 7, 2021
@benjamintboyle benjamintboyle deleted the remove-toolversion-for-jacoco-and-checkstyle branch May 7, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants