Merge of Pull 657: Average and Sum

[benjchristensen]

No description provided.

[cloudbees-pull-request-builder]

RxJava-pull-requests #615 SUCCESS
This pull request looks good

[DavidMGross]

I'm not crazy about the naming:

average() / averageInteger(f)
averageDoubles() / averageDouble(f)
averageFloats() / averageFloat(f)
averageLongs() / averageLong(f)

It doesn't seem to have much rhyme or reason to it. Why are the versions
that take functions singular and the versions that don't are plural (e.g.
"Long" vs "Longs")? Why is the function paired up with averageInteger(f)
just called average() instead of averageIntegers(), when all the other
functions follow that pattern?

On Fri, Dec 27, 2013 at 1:18 PM, CloudBees pull request builder plugin <
[email protected]> wrote:

RxJava-pull-requests #615https://netflixoss.ci.cloudbees.com/job/RxJava-pull-requests/615/SUCCESS
This pull request looks good

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/698#issuecomment-31280530
.

David M. Gross
PLP Consulting

[akarnokd]

• I wanted to avoid overload problems in other languages and simply named the ops differently.
• I wondered why average() didn't include the type in the name. Is it more common to average a stream of ints?
• I wondered why the originals where plurals in the first place.

[benjchristensen]

I wanted to avoid overload problems in other languages and simply named the ops differently.

This is actually a problem with type-erasure, not the language interop.

This code ...

public static Observable<Integer> average(Observable<Integer> source) {
        return OperationAverage.average(source);
}

public static Observable<Double> average(Observable<Double> source) {
        return OperationAverage.average(source);
}

Results in this error:

Method average(Observable) has the same erasure average(Observable) as another method in type Observable

[benjchristensen]

We can rename the methods. Doing so now.

[benjchristensen]

Names standardized here: benjchristensen@f8fc1cb