Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New contrib module: rxjava-async-util #696

Closed
wants to merge 1 commit into from
Closed

New contrib module: rxjava-async-util #696

wants to merge 1 commit into from

Conversation

benjchristensen
Copy link
Member

@benjchristensen
New contrib module: rxjava-async-util
dda3b79 
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core.

As per discussions at:

- ReactiveX#646 (comment)
- ReactiveX#645 (comment)
- ReactiveX#622 (comment)
@benjchristensen
Copy link
Member Author

@akarnokd Do you want to extend this branch and merge the various PRs in to it that belong here?

If you don't like the name go ahead and propose something, I couldn't think of anything better but only spent a couple minutes on this.

I want something generic enough to cover the various utilities. At the same time I feel this name may be too broad as these utilities may not apply at all to other JVM languages, but that's probably fine as that's why it's a contrib module.

This was referenced Dec 27, 2013
Closed
Closed
Closed
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #613 FAILURE
Looks like there's a problem with this pull request

@akarnokd
Copy link
Member

Thanks @benjchristensen the name is okay. I'll update and resubmit the relevant PRs. Should Observable.from(Future) and its overloads from before be moved into this module?

@benjchristensen
Copy link
Member Author

Leave Observable.from(Future) in Observable for now. We'll need to do a deprecation process on those if we remove them.

@benjchristensen
Copy link
Member Author

I'm closing this PR as you will take my branch and re-submit a new one.

@akarnokd
Copy link
Member

I'm sorry I don't quite understand. I check out your branch then, once all ops are added, I submit a PR against RXJava/master?

@benjchristensen
Copy link
Member Author

Yes.

@benjchristensen benjchristensen deleted the rxjava-async-util branch December 30, 2013 17:32
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@kdombeck @RobWin
Allow configuration of Prometheus buckets (ReactiveX#696)
a0a5600 
* Allow for configuring of Prometheus Histogram buckets

* Created new MetricOptions class to allow for custom Histogram buckets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjchristensen @cloudbees-pull-request-builder @akarnokd