Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaDocs of Single.doOnTerminate refer to onComplete notification #6565

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Fix JavaDocs of Single.doOnTerminate refer to onComplete notification #6565

merged 1 commit into from
Jul 15, 2019

Conversation

SupasinTatiyanupanwong
Copy link

As mentioned in JavaDocs of this class that Single does not have "onComplete" notification.
This newly introduced method refer to that notification, which looks to me it should be onSuccess instead.

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (2.x@5c83b50). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             2.x    #6565   +/-   ##
======================================
  Coverage       ?   98.24%           
  Complexity     ?     6333           
======================================
  Files          ?      677           
  Lines          ?    45488           
  Branches       ?     6321           
======================================
  Hits           ?    44691           
  Misses         ?      244           
  Partials       ?      553
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 149 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c83b50...9d9ef71. Read the comment docs.

@akarnokd akarnokd merged commit 5550b63 into ReactiveX:2.x Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants