-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Javadoc of flattenAsFlowable and flattenAsObservable method #6408
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6408 +/- ##
============================================
+ Coverage 98.22% 98.27% +0.05%
+ Complexity 6298 6294 -4
============================================
Files 675 675
Lines 45172 45172
Branches 6246 6246
============================================
+ Hits 44371 44395 +24
+ Misses 260 241 -19
+ Partials 541 536 -5
Continue to review full report at Codecov.
|
b4edb8c
to
73f957a
Compare
@akarnokd The force push only involves changing my email in the previous commit. Apologies for the confusion.. I'm not sure why the build has failed.
|
@akarnokd I closed and reopened the PR to enable a rebuild and this time it has passed. Was there any transient known build failures here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a flaky test caused the failure.
Thanks. That test should be deterministic and not fail, unless there is a bug in concatMap's backpressure management. Did you save the full stacktrace of the failure by any chance? |
@akarnokd Actually, that is all I saw as part of the failure. This was the failing build - https://travis-ci.org/ReactiveX/RxJava/builds/494276690 |
Improving the javadoc of the
flattenAsFlowable
andflattenAsObservable
methods ofSingle
andMaybe
classes.Resolves: #6276