Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Javadoc of flattenAsFlowable and flattenAsObservable method #6408

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

thiyagu-7
Copy link
Contributor

@thiyagu-7 thiyagu-7 commented Feb 16, 2019

Improving the javadoc of the flattenAsFlowable and flattenAsObservable methods of Single and Maybe classes.

Resolves: #6276

@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #6408 into 2.x will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6408      +/-   ##
============================================
+ Coverage     98.22%   98.27%   +0.05%     
+ Complexity     6298     6294       -4     
============================================
  Files           675      675              
  Lines         45172    45172              
  Branches       6246     6246              
============================================
+ Hits          44371    44395      +24     
+ Misses          260      241      -19     
+ Partials        541      536       -5
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 173 <0> (ø) ⬇️
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 149 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-2.39%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 86.27% <0%> (-1.31%) 2% <0%> (ø)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184a17b...73f957a. Read the comment docs.

@thiyagu-7
Copy link
Contributor Author

@akarnokd The force push only involves changing my email in the previous commit. Apologies for the confusion.. I'm not sure why the build has failed.

io.reactivex.internal.operators.flowable.FlowableConcatMapTest > boundaryFusionDelayError FAILED
java.lang.AssertionError: Error(s) present: [io.reactivex.exceptions.MissingBackpressureException: Queue is full?!] (latch = 0, values = 1, errors = 1, completions = 0)
at io.reactivex.observers.BaseTestConsumer.fail(BaseTestConsumer.java:189)
at io.reactivex.observers.BaseTestConsumer.assertNoErrors(BaseTestConsumer.java:274)
at io.reactivex.observers.BaseTestConsumer.assertResult(BaseTestConsumer.java:797)
at io.reactivex.internal.operators.flowable.FlowableConcatMapTest.boundaryFusionDelayError(FlowableConcatMapTest.java:105)
Caused by:
io.reactivex.exceptions.MissingBackpressureException: Queue is full?!

@thiyagu-7 thiyagu-7 closed this Feb 16, 2019
@thiyagu-7 thiyagu-7 reopened this Feb 16, 2019
@thiyagu-7
Copy link
Contributor Author

@akarnokd I closed and reopened the PR to enable a rebuild and this time it has passed. Was there any transient known build failures here?

Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a flaky test caused the failure.

@akarnokd
Copy link
Member

Thanks. That test should be deterministic and not fail, unless there is a bug in concatMap's backpressure management. Did you save the full stacktrace of the failure by any chance?

@akarnokd akarnokd merged commit add2812 into ReactiveX:2.x Feb 16, 2019
@thiyagu-7
Copy link
Contributor Author

@akarnokd Actually, that is all I saw as part of the failure.

This was the failing build - https://travis-ci.org/ReactiveX/RxJava/builds/494276690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants