2.x: Don't dispose the winner of {Single|Maybe|Completable}.amb() #6375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
Single.amb
,Maybe.amb
andCompletable.amb
operators to not dispose the winner source, causing potential interruptions as a side-effect on the current thread.The fix is to delete the winner from the composite before disposing the rest to avoid the interruption race.
Unit tests were added to verify this behavior on all
amb
implementations.Flowable
andObservable
were already working correctly.Fixes: #6373