2.x: Fix bounded replay() memory leak due to bad node retention #6371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak caused by node retention in the bounded
replay()
implementations. When the consumer disposed/canceled the flow, theindex
field was not cleared. In certain situations, such out-of-comission consumers were still reachable via thread local stack and through it, the node they were last refencing. Further items through it would then keep referencing an ever increasing number of linked nodes, causing OOME eventually.The fix is to clear the
index
field upon dispose/cancellation. The subject/processor variants were working properly. Tests were added to verify them though as well.Issue discovered on StackOverflow: https://stackoverflow.com/q/54191190/61158