-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace indexed loop with for-each java5 syntax #6335
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6335 +/- ##
============================================
+ Coverage 98.23% 98.26% +0.03%
- Complexity 6284 6285 +1
============================================
Files 672 672
Lines 44992 44990 -2
Branches 6223 6223
============================================
+ Hits 44198 44210 +12
+ Misses 253 248 -5
+ Partials 541 532 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the original indexed loops were optimizations, please restore them. The other changes are fine.
src/main/java/io/reactivex/internal/operators/parallel/ParallelJoin.java
Outdated
Show resolved
Hide resolved
src/main/java/io/reactivex/internal/operators/parallel/ParallelJoin.java
Outdated
Show resolved
Hide resolved
src/main/java/io/reactivex/internal/operators/parallel/ParallelJoin.java
Outdated
Show resolved
Hide resolved
src/main/java/io/reactivex/internal/operators/parallel/ParallelJoin.java
Outdated
Show resolved
Hide resolved
src/main/java/io/reactivex/internal/operators/parallel/ParallelJoin.java
Show resolved
Hide resolved
src/main/java/io/reactivex/internal/operators/parallel/ParallelJoin.java
Show resolved
Hide resolved
@akarnokd thank you for code review and assistance |
Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:
Please give a description about what and why you are contributing, even if it's trivial.
Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.
Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an
empty
,just
,range
of values as well as anerror
source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.