Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace indexed loop with for-each java5 syntax #6335

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Replace indexed loop with for-each java5 syntax #6335

merged 3 commits into from
Dec 19, 2018

Conversation

igor-suhorukov
Copy link
Contributor

Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:

  • Please give a description about what and why you are contributing, even if it's trivial.

  • Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

  • Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an empty, just, range of values as well as an error source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.

@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #6335 into 2.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6335      +/-   ##
============================================
+ Coverage     98.23%   98.26%   +0.03%     
- Complexity     6284     6285       +1     
============================================
  Files           672      672              
  Lines         44992    44990       -2     
  Branches       6223     6223              
============================================
+ Hits          44198    44210      +12     
+ Misses          253      248       -5     
+ Partials        541      532       -9
Impacted Files Coverage Δ Complexity Δ
...ivex/internal/operators/parallel/ParallelJoin.java 94.81% <100%> (-0.04%) 3 <0> (ø)
...nternal/operators/observable/ObservableCreate.java 93.16% <0%> (-5.13%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-2.5%) 2% <0%> (ø)
...ex/internal/operators/flowable/FlowableCreate.java 95.8% <0%> (-1.94%) 6% <0%> (ø)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...tivex/internal/operators/single/SingleTimeout.java 98.33% <0%> (-1.67%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 90.84% <0%> (-1.31%) 2% <0%> (ø)
...io/reactivex/subscribers/SerializedSubscriber.java 98.86% <0%> (-1.14%) 26% <0%> (-1%)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 97.54% <0%> (-0.82%) 2% <0%> (ø)
...ternal/operators/observable/ObservableTimeout.java 99.36% <0%> (-0.64%) 3% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae765a...8eccac2. Read the comment docs.

Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the original indexed loops were optimizations, please restore them. The other changes are fine.

@igor-suhorukov
Copy link
Contributor Author

@akarnokd thank you for code review and assistance

@akarnokd akarnokd dismissed their stale review December 10, 2018 22:25

updated by the poster

@akarnokd akarnokd added this to the 2.2 backlog milestone Dec 11, 2018
@akarnokd akarnokd merged commit 5278124 into ReactiveX:2.x Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants