Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Expand and fix Completable.delaySubscription tests #6252

Merged

Conversation

akarnokd
Copy link
Member

Expand, fix and move the tests of #6242 into a dedicated test file.

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (2.x@f78bd95). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             2.x    #6252   +/-   ##
======================================
  Coverage       ?   98.23%           
  Complexity     ?     6205           
======================================
  Files          ?      667           
  Lines          ?    44889           
  Branches       ?     6216           
======================================
  Hits           ?    44095           
  Misses         ?      261           
  Partials       ?      533

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78bd95...4e778d6. Read the comment docs.

@akarnokd akarnokd merged commit 2fb9504 into ReactiveX:2.x Oct 19, 2018
@akarnokd akarnokd deleted the CompletableDelaySubscriptionTestAdditions branch October 19, 2018 08:54
Completable.fromAction(new Action() {
@Override
public void run() throws Exception {
counter.incrementAndGet();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants