Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Make Flowable.fromCallable consistent with the other fromCallables #6158

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

akarnokd
Copy link
Member

Flowable.fromCallable is one of the oldest 2.x operators and was overlooked when the handling of beyond-cancellation error delivery, aka the undeliverable exception handling was implemented across RxJava. This PR resolves this shortcoming by making it consistent with its sibling implementations.

Resolves: #6156

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #6158 into 2.x will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6158      +/-   ##
============================================
+ Coverage     98.22%   98.24%   +0.02%     
- Complexity     6196     6200       +4     
============================================
  Files           667      667              
  Lines         44857    44859       +2     
  Branches       6213     6214       +1     
============================================
+ Hits          44061    44073      +12     
+ Misses          251      248       -3     
+ Partials        545      538       -7
Impacted Files Coverage Δ Complexity Δ
...ernal/operators/flowable/FlowableFromCallable.java 100% <100%> (ø) 4 <0> (+1) ⬆️
...rnal/operators/flowable/FlowableFlatMapSingle.java 93.47% <0%> (-2.18%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ex/internal/operators/flowable/FlowableCreate.java 96.12% <0%> (-1.62%) 6% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 99.11% <0%> (-0.89%) 10% <0%> (-1%)
...l/operators/observable/ObservableTimeoutTimed.java 99.15% <0%> (-0.85%) 3% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-0.75%) 2% <0%> (ø)
...vex/internal/operators/flowable/FlowableCache.java 97.94% <0%> (-0.69%) 10% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 94.68% <0%> (-0.54%) 3% <0%> (ø)
...main/java/io/reactivex/subjects/ReplaySubject.java 97.69% <0%> (-0.42%) 50% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 835ab00...1c7348a. Read the comment docs.

@akarnokd akarnokd changed the title 2.x: Make Flowable.fromCallable consitent with the other fromCallables 2.x: Make Flowable.fromCallable consistent with the other fromCallables Aug 14, 2018
@akarnokd akarnokd merged commit 7d65291 into ReactiveX:2.x Aug 14, 2018
@akarnokd akarnokd deleted the FlowableFromCallableUndeliverable branch August 14, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.x: Why ObservableFromCallable logic differs from FlowableFromCallable when error occurs
2 participants