-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Add marbles for Single.concat operator #6137
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6137 +/- ##
============================================
+ Coverage 98.25% 98.26% +0.01%
+ Complexity 6197 6194 -3
============================================
Files 667 667
Lines 44853 44853
Branches 6213 6213
============================================
+ Hits 44069 44074 +5
+ Misses 237 236 -1
+ Partials 547 543 -4
Continue to review full report at Codecov.
|
|
Thanks for explanation! Marbles are now updated per comments |
The |
Based on a comment I thought that only |
Here are marbles for
concat(Iterable)
,concat(Publisher)
,concat(Publisher, prefetch)
,concat(Observable)
,concat(source1, source2)
,concat(source1, source2, source3)
,concat(source1, source2, source3, source4)
andconcatArray
operators that should close them at #5788 .Marble for
concat(Iterable)
Marble for
concat(Publisher)
Marble for
concat(Publisher, prefetch)
Marble for
concat(Observable)
Marble for
concat(source1, source2)
Marble for
concat(source1, source2, source3)
Marble for
concat(source1, source2, source3, source4)
Marble for
concatArray
Please pay attention to file names in javadoc as I was not sure how to name
concat(Iterable)
so I've added at the endi
, forconcat(Observable)
I've addedo
. Forconcat(source1, source2, source3)
andconcat(source1, source2, source3, source4)
I've usedn
andm
as they are numerical values.Also, is there an error in
concat(Publisher)
andconcat(Publisher, prefetch)
withrequest()
commands? I did used as a referenceCompletable.concat(Publisher)
marble but I do not understand why do we haverequest(1)
after first event as we already requested prefetching of multiple ones. Is it because others are still not produced?Thanks