-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Remove fromEmitter() in wiki #6128
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6128 +/- ##
============================================
- Coverage 98.27% 98.24% -0.03%
- Complexity 6192 6195 +3
============================================
Files 667 667
Lines 44853 44853
Branches 6213 6213
============================================
- Hits 44079 44067 -12
+ Misses 239 238 -1
- Partials 535 548 +13
Continue to review full report at Codecov.
|
docs/Creating-Observables.md
Outdated
@@ -3,7 +3,6 @@ This page shows methods that create Observables. | |||
* [**`just( )`**](http://reactivex.io/documentation/operators/just.html) — convert an object or several objects into an Observable that emits that object or those objects | |||
* [**`from( )`**](http://reactivex.io/documentation/operators/from.html) — convert an Iterable, a Future, or an Array into an Observable | |||
* [**`create( )`**](http://reactivex.io/documentation/operators/create.html) — **advanced use only!** create an Observable from scratch by means of a function, consider `fromEmitter` instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the "consider fromEmitter
instead" from this line as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's my mistake. I'm sorry for that.
You should not keep the welcome text and please provide some reasonable description about what you contribute next time. This text is as much for the reviewers of your PR as is for the search engines. |
Thanks for your suggestion. @akarnokd |
Remove the mentions of
fromEmitter
from theCreating-Observables.md
wiki page.