Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Remove fromEmitter() in wiki #6128

Merged
merged 1 commit into from
Aug 2, 2018
Merged

2.x: Remove fromEmitter() in wiki #6128

merged 1 commit into from
Aug 2, 2018

Conversation

CoXier
Copy link
Contributor

@CoXier CoXier commented Aug 2, 2018

Remove the mentions of fromEmitter from the Creating-Observables.md wiki page.

@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #6128 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6128      +/-   ##
============================================
- Coverage     98.27%   98.24%   -0.03%     
- Complexity     6192     6195       +3     
============================================
  Files           667      667              
  Lines         44853    44853              
  Branches       6213     6213              
============================================
- Hits          44079    44067      -12     
+ Misses          239      238       -1     
- Partials        535      548      +13
Impacted Files Coverage Δ Complexity Δ
...nternal/operators/observable/ObservableCreate.java 94.01% <0%> (-4.28%) 2% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-2.39%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...vex/internal/operators/single/SingleTakeUntil.java 98.3% <0%> (-1.7%) 2% <0%> (ø)
...internal/operators/flowable/FlowableFromArray.java 94.91% <0%> (-1.7%) 3% <0%> (ø)
...x/internal/operators/flowable/FlowableGroupBy.java 94.95% <0%> (-1.69%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-1.64%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-1.5%) 2% <0%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30afb3b...be54bba. Read the comment docs.

@@ -3,7 +3,6 @@ This page shows methods that create Observables.
* [**`just( )`**](http://reactivex.io/documentation/operators/just.html) — convert an object or several objects into an Observable that emits that object or those objects
* [**`from( )`**](http://reactivex.io/documentation/operators/from.html) — convert an Iterable, a Future, or an Array into an Observable
* [**`create( )`**](http://reactivex.io/documentation/operators/create.html) — **advanced use only!** create an Observable from scratch by means of a function, consider `fromEmitter` instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the "consider fromEmitter instead" from this line as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my mistake. I'm sorry for that.

@akarnokd
Copy link
Member

akarnokd commented Aug 2, 2018

You should not keep the welcome text and please provide some reasonable description about what you contribute next time. This text is as much for the reviewers of your PR as is for the search engines.

@CoXier
Copy link
Contributor Author

CoXier commented Aug 2, 2018

Thanks for your suggestion. @akarnokd

@akarnokd akarnokd merged commit 2274c42 into ReactiveX:2.x Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants