Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix Completable mergeX JavaDoc missing dt before dd #6103

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jul 20, 2018

Couple of the <dt><b>Error handling:</b></dt> subheaders were missing from various Completable.mergeX operators in the JavaDocs.

@akarnokd akarnokd added this to the 2.2 milestone Jul 20, 2018
@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #6103 into 2.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6103      +/-   ##
============================================
+ Coverage     98.24%   98.25%   +0.01%     
  Complexity     6197     6197              
============================================
  Files           667      667              
  Lines         44862    44862              
  Branches       6213     6213              
============================================
+ Hits          44075    44081       +6     
+ Misses          243      236       -7     
- Partials        544      545       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 117 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 85.62% <0%> (-6.54%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-2.39%) 2% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 94.68% <0%> (-1.6%) 3% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a18fd...6ed11f3. Read the comment docs.

@akarnokd akarnokd merged commit c5a42a2 into ReactiveX:2.x Jul 20, 2018
@akarnokd akarnokd deleted the CompletableJavadocFixes720 branch July 20, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants