Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marbles for Single.timer, Single.defer and Single.toXXX operators #6095

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

UMFsimke
Copy link
Contributor

Here are marbles for defer, timer(delay, unit), timer(delay, unit, scheduler), toFlowable, toMaybe, toFuture operators in #5788

Marble for defer:
defer

Marble for timer(delay, unit):
timer

Marble for timer(delay, unit, scheduler):
timerScheduler

Marble for toFuture, although for this one I believe we should add case when there is no event sent from Single as there will be timeout exception thrown:
toFuture

Marble for toMaybe:
toMaybe

Marble for toFlowable, although here I didnt figured out what will happen if we request more than 1 event from flowable:
toFlowable

@akarnokd
Copy link
Member

defer: I would have drawn it with a curly brace listing the 3 options below each other. Please add the subscribe() indicators as well.

toFuture: I indicate Future with a 6-sided shape and indicate get() call and a return. See Completable.fromFuture for an example.

toFlowable: simply indicate request(N). Any positive N has the same effect with this operator. However, an error is always pushed through even without a request; just remove the request(1) from that side of the diagram.

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #6095 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6095      +/-   ##
============================================
- Coverage     98.26%   98.26%   -0.01%     
+ Complexity     6194     6190       -4     
============================================
  Files           667      667              
  Lines         44858    44861       +3     
  Branches       6211     6213       +2     
============================================
+ Hits          44081    44082       +1     
  Misses          234      234              
- Partials        543      545       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 146 <0> (ø) ⬇️
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 90.84% <0%> (-3.27%) 2% <0%> (ø)
...ex/internal/subscriptions/SubscriptionArbiter.java 97.45% <0%> (-2.55%) 47% <0%> (-1%)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...o/reactivex/internal/schedulers/SchedulerWhen.java 97.64% <0%> (-2.36%) 5% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 97.02% <0%> (-2.13%) 11% <0%> (ø)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 96.29% <0%> (-1.86%) 38% <0%> (-1%)
...ex/internal/operators/flowable/FlowableCreate.java 95.8% <0%> (-1.62%) 6% <0%> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aeac06...d337e9b. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 milestone Jul 19, 2018
@akarnokd akarnokd modified the milestones: 2.2, 2.2 backlog Jul 31, 2018
@akarnokd
Copy link
Member

akarnokd commented Aug 1, 2018

@UMFsimke are you still around?

@UMFsimke
Copy link
Contributor Author

UMFsimke commented Aug 1, 2018

Yes. I have in plan to wrap it up today... sorry for delay I was on vacation

@UMFsimke
Copy link
Contributor Author

UMFsimke commented Aug 1, 2018

@akarnokd Are these ok now?

I'm a bit confused by what you exactly had in mind for defer and toFuture.

Please update me if they are fine as I do need to update image sizes in javadoc.
tofuture
toflowable
defer

@akarnokd
Copy link
Member

akarnokd commented Aug 1, 2018

Yes, these are okay.

@UMFsimke
Copy link
Contributor Author

UMFsimke commented Aug 1, 2018

Thanks. Updated javadoc.

@akarnokd akarnokd merged commit c0f17ce into ReactiveX:2.x Aug 2, 2018
@UMFsimke UMFsimke deleted the SingleMarbles719a branch August 4, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants