-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marbles for Single.timer, Single.defer and Single.toXXX operators #6095
Conversation
defer: I would have drawn it with a curly brace listing the 3 options below each other. Please add the subscribe() indicators as well. toFuture: I indicate Future with a 6-sided shape and indicate get() call and a return. See Completable.fromFuture for an example. toFlowable: simply indicate request(N). Any positive N has the same effect with this operator. However, an error is always pushed through even without a request; just remove the request(1) from that side of the diagram. |
Codecov Report
@@ Coverage Diff @@
## 2.x #6095 +/- ##
============================================
- Coverage 98.26% 98.26% -0.01%
+ Complexity 6194 6190 -4
============================================
Files 667 667
Lines 44858 44861 +3
Branches 6211 6213 +2
============================================
+ Hits 44081 44082 +1
Misses 234 234
- Partials 543 545 +2
Continue to review full report at Codecov.
|
@UMFsimke are you still around? |
Yes. I have in plan to wrap it up today... sorry for delay I was on vacation |
@akarnokd Are these ok now? I'm a bit confused by what you exactly had in mind for Please update me if they are fine as I do need to update image sizes in javadoc. |
Yes, these are okay. |
Thanks. Updated javadoc. |
Here are marbles for
defer
,timer(delay, unit)
,timer(delay, unit, scheduler)
,toFlowable
,toMaybe
,toFuture
operators in #5788Marble for
defer
:Marble for
timer(delay, unit)
:Marble for
timer(delay, unit, scheduler)
:Marble for
toFuture
, although for this one I believe we should add case when there is no event sent from Single as there will be timeout exception thrown:Marble for
toMaybe
:Marble for
toFlowable
, although here I didnt figured out what will happen if we request more than 1 event from flowable: