-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marble diagram to the Single.filter method #6075
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6075 +/- ##
============================================
- Coverage 98.25% 98.23% -0.03%
Complexity 6191 6191
============================================
Files 666 666
Lines 44806 44806
Branches 6206 6206
============================================
- Hits 44026 44017 -9
- Misses 234 242 +8
- Partials 546 547 +1
Continue to review full report at Codecov.
|
|
PR is updated. Thanks for explanation 👍 |
Hopefully this should tick off the
filter
operator in #5788Please let me know if I need to change anything on the diagram itself. If not, please send me URL when you upload image within the project so I can change URL for the marble in the PR.
Although, I had a doubt and wanted to double check. Operator
filter
returnsMaybe
which essentially will callonSuccess
oronComplete
. By running jUnit tests, I could observe that this is a behavior but if I useTestObserver
then bothassertValue()
andassertComplete()
are invoked when there are elements that satisfyfilter
condition.