Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marble diagram to the Single.never method #6074

Merged
merged 2 commits into from
Jul 8, 2018

Conversation

UMFsimke
Copy link
Contributor

@UMFsimke UMFsimke commented Jul 7, 2018

First of all, I'm extremely grateful to open my first PR for RxJava. I hope that I'll be able to tick more of the marbles from #5788 but for now this should tick off the never operator.

Please let me know if I need to change anything on the diagram itself. If not, please send me URL when you upload image within the project so I can change URL for the marble in the PR.

@codecov
Copy link

codecov bot commented Jul 7, 2018

Codecov Report

Merging #6074 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6074      +/-   ##
============================================
+ Coverage     98.24%   98.28%   +0.03%     
+ Complexity     6192     6190       -2     
============================================
  Files           666      666              
  Lines         44806    44806              
  Branches       6206     6206              
============================================
+ Hits          44020    44036      +16     
+ Misses          239      236       -3     
+ Partials        547      534      -13
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 146 <0> (ø) ⬇️
...a/io/reactivex/internal/util/QueueDrainHelper.java 95.83% <0%> (-2.78%) 55% <0%> (-2%)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <0%> (-2.25%) 60% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-2.14%) 5% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.2% <0%> (-1.45%) 2% <0%> (ø)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 84.96% <0%> (-0.66%) 2% <0%> (ø)
...ain/java/io/reactivex/subjects/UnicastSubject.java 99.36% <0%> (-0.64%) 64% <0%> (-1%)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909920a...19cb68e. Read the comment docs.

@akarnokd
Copy link
Member

akarnokd commented Jul 8, 2018

https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.never.png

@UMFsimke
Copy link
Contributor Author

UMFsimke commented Jul 8, 2018

Thank you! PR is updated :)

@akarnokd akarnokd merged commit e29b57b into ReactiveX:2.x Jul 8, 2018
@akarnokd akarnokd added this to the 2.2 milestone Jul 8, 2018
@UMFsimke UMFsimke deleted the SingleNeverOperatorMarbles branch July 8, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants