-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DESIGN.md #6033
Merged
Merged
Update DESIGN.md #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've just read the DESIGN.md and noticed some things that I could do to improve the quality of the DESIGN.md. So as a result of my "proofreading" I mainly: - Added periods at the ending of some sentences. - Did case matching of certain types and terms. e.g. `OnSubscribe` -> `onSubscribe` OR flowable -> `Flowable`. Hope it helps! 😄
Codecov Report
@@ Coverage Diff @@
## 2.x #6033 +/- ##
===========================================
+ Coverage 98.25% 98.35% +0.1%
Complexity 6171 6171
===========================================
Files 665 665
Lines 44729 44729
Branches 6205 6205
===========================================
+ Hits 43949 43995 +46
+ Misses 237 213 -24
+ Partials 543 521 -22
Continue to review full report at Codecov.
|
Great, I hope you take a look at other documentation as well! |
akarnokd
approved these changes
Jun 1, 2018
artem-zinnatullin
approved these changes
Jun 1, 2018
vanniktech
approved these changes
Jun 1, 2018
Thank you! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just read the DESIGN.md and noticed some things that I could do to improve the quality of the DESIGN.md. So as a result of my "proofreading" I mainly:
OnSubscribe
->onSubscribe
OR flowable ->Flowable
.Hope it helps! 😄