-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marble diagrams to a few Single.doOnX methods. #5987
Conversation
Thanks for the PR. There are a couple of things to be changed on the diagrams. Once done, I'll upload them into this repo and provide you with the proper URLs so you can update this PR. |
Sure, will get these fixed tonight :) |
@@ -2173,6 +2173,9 @@ | |||
* is executed once per subscription. | |||
* <p>Note that the {@code onFinally} action is shared between subscriptions and as such | |||
* should be thread-safe. | |||
* <p> | |||
* <img width="1040" height="472" src="https://user-images.githubusercontent.com/4089934/39448132-dca93836-4cbb-11e8-9b13-ce078a8ba206.png" alt=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Images should be 640 width and the height should be reduced to keep the aspect ratio. In this case, 2079x945 -> 640x290
Codecov Report
@@ Coverage Diff @@
## 2.x #5987 +/- ##
============================================
+ Coverage 98.22% 98.25% +0.02%
+ Complexity 6053 6051 -2
============================================
Files 656 656
Lines 44078 44078
Branches 6118 6118
============================================
+ Hits 43297 43309 +12
Misses 235 235
+ Partials 546 534 -12
Continue to review full report at Codecov.
|
Great, here are the links: https://raw.githubusercontent.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.doFinally.png Some images existed but we don't change those to avoid conflicts with the ReactiveX site linking to them. |
This should tick a few tasks from this issue: #5788.
The urls are a bit ugly, as they're from the uploads in the issue. I'm happy to update the urls with different ones if there's a better place to upload the diagrams.