Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marble diagrams to a few Single.doOnX methods. #5987

Merged
merged 2 commits into from
May 1, 2018

Conversation

VeskoI
Copy link
Contributor

@VeskoI VeskoI commented Apr 30, 2018

This should tick a few tasks from this issue: #5788.

The urls are a bit ugly, as they're from the uploads in the issue. I'm happy to update the urls with different ones if there's a better place to upload the diagrams.

@akarnokd
Copy link
Member

Thanks for the PR. There are a couple of things to be changed on the diagrams. Once done, I'll upload them into this repo and provide you with the proper URLs so you can update this PR.

@akarnokd akarnokd added this to the 2.2 milestone Apr 30, 2018
@VeskoI
Copy link
Contributor Author

VeskoI commented Apr 30, 2018

Sure, will get these fixed tonight :)

@@ -2173,6 +2173,9 @@
* is executed once per subscription.
* <p>Note that the {@code onFinally} action is shared between subscriptions and as such
* should be thread-safe.
* <p>
* <img width="1040" height="472" src="https://user-images.githubusercontent.com/4089934/39448132-dca93836-4cbb-11e8-9b13-ce078a8ba206.png" alt="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images should be 640 width and the height should be reduced to keep the aspect ratio. In this case, 2079x945 -> 640x290

@VeskoI
Copy link
Contributor Author

VeskoI commented Apr 30, 2018

Hope these are better:

single_dofinally
single_doondispose
single_doonsubscribe

@codecov
Copy link

codecov bot commented Apr 30, 2018

Codecov Report

Merging #5987 into 2.x will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5987      +/-   ##
============================================
+ Coverage     98.22%   98.25%   +0.02%     
+ Complexity     6053     6051       -2     
============================================
  Files           656      656              
  Lines         44078    44078              
  Branches       6118     6118              
============================================
+ Hits          43297    43309      +12     
  Misses          235      235              
+ Partials        546      534      -12
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 146 <0> (ø) ⬇️
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-3.23%) 9% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.33% <0%> (-1.94%) 2% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 94.11% <0%> (-1.07%) 5% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.06% <0%> (-0.94%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 97.54% <0%> (-0.82%) 2% <0%> (ø)
...vex/internal/operators/flowable/FlowableCache.java 97.94% <0%> (-0.69%) 10% <0%> (-1%)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57af5a...d6059a1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants