-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Fix Flowable.take to route post-cancel errors to RxJavaPlugins.onError #5978
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5978 +/- ##
===========================================
+ Coverage 98.2% 98.23% +0.03%
+ Complexity 6052 6049 -3
===========================================
Files 656 656
Lines 44077 44078 +1
Branches 6118 6118
===========================================
+ Hits 43287 43302 +15
+ Misses 243 232 -11
+ Partials 547 544 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ObservableLimitTest already has this unit test?
Not this specific one. |
If this is tested in a different test then fine, otherwise it might make sense to also add it. |
There is no |
Alright. Then merge. |
This PR makes sure errors emitted by the upstream just after the
Flowable.take
has received the specified amount of items get routed toRxJavaPlugins.onError
.Observable.take()
andFlowable.limit()
were already doing this. Added unit tests to verify the behavior across the board.