Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add Subject and Processor marbles #5816

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

akarnokd
Copy link
Member

This PR adds the missing marble diagrams to the various Subject and Processor implementations:

AsyncSubject

AsyncSubject

PublishSubject

PublishSubject

ReplaySubject

ReplaySubject1
ReplaySubject2
ReplaySubject3
ReplaySubject4
ReplaySubject5

CompletableSubject

CompletableSubject

SingleSubject

SingleSubject

MaybeSubject

MaybeSubject

AsyncProcessor

AsyncProcessor

PublishProcessor

PublishProcessor

ReplayProcessor

ReplayProcessor1
ReplayProcessor2
ReplayProcessor3
ReplayProcessor4
ReplayProcessor5

@akarnokd akarnokd added this to the 2.2 milestone Jan 19, 2018
@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #5816 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #5816      +/-   ##
===========================================
+ Coverage     96.4%   96.44%   +0.03%     
- Complexity    5816     5817       +1     
===========================================
  Files          634      634              
  Lines        41761    41761              
  Branches      5796     5796              
===========================================
+ Hits         40259    40275      +16     
- Misses         574      575       +1     
+ Partials       928      911      -17
Impacted Files Coverage Δ Complexity Δ
...java/io/reactivex/processors/PublishProcessor.java 98.23% <ø> (ø) 43 <0> (ø) ⬇️
...n/java/io/reactivex/processors/AsyncProcessor.java 99.08% <ø> (ø) 52 <0> (ø) ⬇️
...main/java/io/reactivex/subjects/ReplaySubject.java 97.33% <ø> (ø) 49 <0> (ø) ⬇️
.../java/io/reactivex/processors/ReplayProcessor.java 99.35% <ø> (ø) 51 <0> (ø) ⬇️
...main/java/io/reactivex/subjects/SingleSubject.java 100% <ø> (ø) 38 <0> (ø) ⬇️
.../main/java/io/reactivex/subjects/MaybeSubject.java 100% <ø> (ø) 46 <0> (ø) ⬇️
...ain/java/io/reactivex/subjects/PublishSubject.java 97.8% <ø> (-2.2%) 38 <0> (-1)
.../main/java/io/reactivex/subjects/AsyncSubject.java 99.06% <ø> (ø) 52 <0> (ø) ⬇️
...java/io/reactivex/subjects/CompletableSubject.java 100% <ø> (ø) 36 <0> (ø) ⬇️
...internal/disposables/ArrayCompositeDisposable.java 96.42% <0%> (-3.58%) 15% <0%> (-1%)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb426fd...c9dc6f1. Read the comment docs.

@akarnokd akarnokd merged commit bcc419c into ReactiveX:2.x Jan 22, 2018
@akarnokd akarnokd deleted the ProcessorSubjectMarbles branch January 22, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants