-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2x: Fix wording in Async and Publish processors javadoc. #5444
Conversation
@@ -23,14 +23,14 @@ | |||
import io.reactivex.plugins.RxJavaPlugins; | |||
|
|||
/** | |||
* A Subject that multicasts events to Subscribers that are currently subscribed to it. | |||
* Processor that multicasts all subsequently observed items to its current {@link Subscriber}s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"A Processor" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Replay and Behaviour processors it's "Processor" _(ツ)_/¯. Both seam syntactically correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then the AsyncProcessor
could be adjusted as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
49f0259
to
34c4858
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #5444 +/- ##
============================================
+ Coverage 95.96% 96.04% +0.07%
- Complexity 5793 5794 +1
============================================
Files 631 631
Lines 41297 41297
Branches 5744 5744
============================================
+ Hits 39632 39662 +30
+ Misses 663 654 -9
+ Partials 1002 981 -21
Continue to review full report at Codecov.
|
Seams that these are some leftovers from the 1.x -> 2.x refactoring.