Fix javadoc for Observable.reduce() and Observable.reduceWith() #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also fix Flowable's javadoc? |
|
@akarnokd Done. |
|
The |
akarnokd
reviewed
Jun 11, 2017
| * | ||
| * // alternatively, by using compose to stay fluent | ||
| * | ||
| * source.compose(o -> | ||
| * Publisher.defer(() -> o.reduce(new ArrayList<>(), (list, item) -> list.add(item))) | ||
| * ); | ||
| * Publisher.defer(() -> o.reduce(new ArrayList<>(), (list, item) -> list.add(item)).toFlowable()) |
There was a problem hiding this comment.
This should be Flowable.defer.
|
Updated according to the feedback. |
|
Great! |
Codecov Report
@@ Coverage Diff @@
## 2.x #5406 +/- ##
======================================
Coverage ? 96.19%
Complexity ? 5789
======================================
Files ? 630
Lines ? 41197
Branches ? 5728
======================================
Hits ? 39629
Misses ? 605
Partials ? 963
Continue to review full report at Codecov.
|
This was referenced Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample code given in the javadoc for
Observable.reduce()isn't compiling, since the function returns aSingle.This PR changes it to a compiling example.
It also updates the javadoc for
reduceWith()to better match its actual behaviour.Remark
I'm not sure whether the sample code for
reduce()is needed at all. The problem that it addresses might be solved better by usingreduceWith(), imho.Update
Flowable.reduce()andFlowable.reduceWith()