Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fix flatMapIterable appearing to be empty when fused #5256

Merged
merged 1 commit into from
Apr 1, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Apr 1, 2017

The wrong logical expression in the isEmpty() method made flatMapIterable complete earlier, even if data was available in the current iterable.

Somewhat related: reactor/reactor-core#508 (different logical bug in the same method).

@akarnokd akarnokd added this to the 2.0 backlog milestone Apr 1, 2017
@codecov
Copy link

codecov bot commented Apr 1, 2017

Codecov Report

Merging #5256 into 2.x will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5256      +/-   ##
============================================
+ Coverage     95.95%   95.99%   +0.04%     
+ Complexity     5750     5746       -4     
============================================
  Files           628      628              
  Lines         41075    41077       +2     
  Branches       5698     5699       +1     
============================================
+ Hits          39414    39433      +19     
+ Misses          664      657       -7     
+ Partials        997      987      -10
Impacted Files Coverage Δ Complexity Δ
...al/operators/flowable/FlowableFlattenIterable.java 97.24% <66.66%> (+0.02%) 4 <0> (ø) ⬇️
...rnal/subscriptions/ArrayCompositeSubscription.java 93.33% <0%> (-6.67%) 17% <0%> (-1%)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...rnal/subscribers/SinglePostCompleteSubscriber.java 94.87% <0%> (-5.13%) 14% <0%> (-1%)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <0%> (-4.62%) 27% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 91.22% <0%> (-4.39%) 9% <0%> (-1%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.13% <0%> (-3.27%) 9% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...main/java/io/reactivex/subjects/SingleSubject.java 95.23% <0%> (-2.39%) 38% <0%> (-1%)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba5edc9...cd6b13f. Read the comment docs.

@akarnokd akarnokd merged commit 5ec4f76 into ReactiveX:2.x Apr 1, 2017
@akarnokd akarnokd deleted the FlattenShareFix branch April 1, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants