2.x UnicastProcessor fail-fast support #5226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
reviewed
Mar 24, 2017
| @CheckReturnValue | ||
| @Experimental | ||
| public static <T> UnicastProcessor<T> create(int capacityHint, Runnable onCancelled, boolean delayError) { | ||
| return new UnicastProcessor<T>(capacityHint, onCancelled,delayError); |
There was a problem hiding this comment.
nit: newline between onCancelled,delayError
| return new UnicastProcessor<T>(capacityHint, onCancelled,delayError); | ||
| } | ||
|
|
||
| /** | ||
| * Creates an UnicastProcessor with the given capacity hint. | ||
| * @param capacityHint the capacity hint for the internal, unbounded queue | ||
| * @since 2.0 | ||
| */ | ||
| UnicastProcessor(int capacityHint) { |
There was a problem hiding this comment.
Is this one really necessary?
There was a problem hiding this comment.
could you elaborate a bit?
Codecov Report
@@ Coverage Diff @@
## 2.x #5226 +/- ##
============================================
+ Coverage 96.01% 96.07% +0.06%
- Complexity 5747 5758 +11
============================================
Files 628 628
Lines 41085 41099 +14
Branches 5698 5703 +5
============================================
+ Hits 39446 39485 +39
+ Misses 657 642 -15
+ Partials 982 972 -10
Continue to review full report at Codecov.
|
akarnokd
requested changes
Mar 24, 2017
| * @param delayError deliver pending onNext events before onError | ||
| * @since 2.0.8 - experimental | ||
| */ | ||
| UnicastProcessor(int capacityHint, boolean delayError) { |
There was a problem hiding this comment.
3 args constructor has non-null onTerminate check; should i move this check to factory?
There was a problem hiding this comment.
Could you move that check into the appropriate create method(s)?
akarnokd
changed the title
…tory methods, fixed typo
akarnokd
approved these changes
Mar 24, 2017
This was referenced Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fail-fast behavior to
UnicastProcessorwith methodsUnicastProcessor<T> create(boolean delayError),UnicastProcessor<T> create(int capacityHint, Runnable onTerminated, boolean delayError). Relates to #5165, #5217