2.x: test to disallow anonymous inner classes #5183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an unit test that scans the compiled .class files for anonymous inner classes naming (i.e., dollar sign followed by a number). Since all the main, test and perf classes end up in the same place, the test has exceptions for file names containing
Perf
orTest
.The PR also fixes a few Checkstyle warnings from #5177 and fixes a couple classes from tests that don't have the word
Test
in their name and thus were detected.