Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Add scheduler creation factories #5002

Merged
merged 12 commits into from
Jan 25, 2017
Merged

2.x: Add scheduler creation factories #5002

merged 12 commits into from
Jan 25, 2017

Commits on Jan 18, 2017

  1. Add scheduler creation factories 

    Resolves ReactiveX#4993

This is a pretty vanilla copy from RxJava 1's implementation. Note that I had to tune NewThread scheduler to not be a singleton to support this.

We had talked about borrowing from project reactor's APIs for different overloads, let me know if you think we should add more fine-grained controls through these.
    @ZacSweers
    ZacSweers committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    2ae2414 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2017

  1. Add @since info

    @ZacSweers
    ZacSweers committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    262f669 View commit details
    Browse the repository at this point in the history

  2. Change failure string to "is null"

    @ZacSweers
    ZacSweers committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    681b977 View commit details
    Browse the repository at this point in the history

  3. Move to RxJavaPlugins

    @ZacSweers
    ZacSweers committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    8b4d461 View commit details
    Browse the repository at this point in the history

  4. Remove no-arg overloads

    @ZacSweers
    ZacSweers committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    8009333 View commit details
    Browse the repository at this point in the history

  5. Rename to make it clearer about creation 

    Added scheduler because we're not in Scheduler anymore. Changed to "create" because "newNewThread" was weird
    @ZacSweers
    ZacSweers committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    66111c5 View commit details
    Browse the repository at this point in the history

  6. Add tests (WIP)

    @ZacSweers
    ZacSweers committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    a1029b4 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary nullcheck

    @ZacSweers
    ZacSweers committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    e5c4a9e View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2017

  1. Remove double try

    @ZacSweers
    ZacSweers committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    90ae664 View commit details
    Browse the repository at this point in the history

  2. Fix tests, make them more robust with integration flow

    @ZacSweers
    ZacSweers committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    6a08b92 View commit details
    Browse the repository at this point in the history

  3. Shut down custom schedulers when done

    @ZacSweers
    ZacSweers committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    ea1ec6c View commit details
    Browse the repository at this point in the history

  4. Merge branch '2.x' into schedulerFactories

    @akarnokd
    akarnokd authored Jan 25, 2017
    Configuration menu
    Copy the full SHA
    00af140 View commit details
    Browse the repository at this point in the history