Merge FlowableEmitter.BackpressureMode into BackpressureStrategy #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.91% (diff: 82.22%)@@ 2.x #4729 diff @@
==========================================
Files 571 571
Lines 37241 37276 +35
Methods 0 0
Messages 0 0
Branches 5671 5678 +7
==========================================
+ Hits 33494 33518 +24
- Misses 2253 2263 +10
- Partials 1494 1495 +1
|
akarnokd
requested changes
Oct 19, 2016
| @@ -9735,6 +9735,12 @@ public final Completable ignoreElements() { | |||
| return RxJavaPlugins.onAssembly(new FlowableOnBackpressureLatest<T>(this)); | |||
| } | |||
|
|
|||
| @BackpressureSupport(BackpressureKind.UNBOUNDED_IN) | |||
There was a problem hiding this comment.
This is the default behavior of most Flowable sources. Unnecessary.
| @BackpressureSupport(BackpressureKind.UNBOUNDED_IN) | ||
| @SchedulerSupport(SchedulerSupport.NONE) | ||
| /*package*/ Flowable<T> onBackpressureError() { | ||
| return RxJavaPlugins.onAssembly(new FlowableOnBackpressureError<T>(this)); |
There was a problem hiding this comment.
Should be inlined in Observable.toFlowable().
| @@ -61,10 +61,13 @@ public void subscribeActual(Subscriber<? super T> t) { | |||
| emitter = new LatestAsyncEmitter<T>(t); | |||
| break; | |||
| } | |||
| default: { | |||
| case BUFFER: { | |||
| TestSubscriber<Integer> ts = Observable.range(1, 5) | ||
| .toFlowable(BackpressureStrategy.ERROR) | ||
| .test(1) | ||
| .assertError(MissingBackpressureException.class); |
There was a problem hiding this comment.
Why not assertFailure(MissingBackpressureException.class, 1) to make sure 1 got through.
| return o; | ||
| case ERROR: | ||
| return o.onBackpressureError(); | ||
| case BUFFER: |
There was a problem hiding this comment.
Please leave these as default: because otherwise the default case can't be coverage-tested.
|
I have implemented the changes from the code comments. |
akarnokd
approved these changes
Oct 19, 2016
|
No need in this case. Looks good to me. |
This was referenced Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of #4727