1.x: rework Single internals to reduce overhead and stack depth #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.03% (diff: 64.75%)@@ 1.x #4648 diff @@
==========================================
Files 274 288 +14
Lines 17766 17991 +225
Methods 0 0
Messages 0 0
Branches 2727 2749 +22
==========================================
+ Hits 15009 15119 +110
- Misses 1889 1996 +107
- Partials 868 876 +8
|
JakeWharton
approved these changes
Oct 1, 2016
|
|
||
| @Override | ||
| public void call(SingleSubscriber<? super T> t) { | ||
| // TODO Auto-generated method stub |
| * Creates a Single with a Function to execute when it is subscribed to (executed). | ||
| * <p> | ||
| * <em>Note:</em> Use {@link #create(OnSubscribe)} to create a Single, instead of this constructor, | ||
| * unless you specifically have a need for inheritance. |
There was a problem hiding this comment.
We could also @Deprecate this constructor.
akarnokd
commented
Oct 2, 2016
| * Creates a Single with a Function to execute when it is subscribed to (executed). | ||
| * <p> | ||
| * <em>Note:</em> Use {@link #create(OnSubscribe)} to create a Single, instead of this constructor, | ||
| * unless you specifically have a need for inheritance. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Single.OnSubscribeas the primary means to execute the subscribe action inSingleand former couple of reusedObservableoperators are now recreated withSingle.OnSubscribe.Because
Singleis now marked final, we can't remove the formerObservable.OperatorandObservable.OnSubscribeentry points (but may be deprecated in a separate PR).