Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Report errors from onError to Plugin when done #4590

Merged
merged 1 commit into from
Sep 23, 2016
Merged

2.x: Report errors from onError to Plugin when done #4590

merged 1 commit into from
Sep 23, 2016

Conversation

vanniktech
Copy link
Collaborator

For the first one that I found I even wrote a test. Then I started noticing more missing spots. If wanted I could port that one test to every operator that I touched. Though I didn't really find tests testing that errors are propagated through the Plugin API.

@codecov-io
Copy link

codecov-io commented Sep 23, 2016

Current coverage is 78.14% (diff: 45.45%)

Merging #4590 into 2.x will increase coverage by 0.06%

@@                2.x      #4590   diff @@
==========================================
  Files           552        552          
  Lines         36220      36247    +27   
  Methods           0          0          
  Messages          0          0          
  Branches       5594       5594          
==========================================
+ Hits          28282      28326    +44   
+ Misses         5927       5914    -13   
+ Partials       2011       2007     -4   

Powered by Codecov. Last update c5e38ce...051df13

@akarnokd akarnokd added the Bug label Sep 23, 2016
@akarnokd akarnokd added this to the 2.0 RC4 milestone Sep 23, 2016
@akarnokd
Copy link
Member

TestHelper has a few generic test methods to check Maybe and Single. The same pattern could be extended to test these without duplicating that long method. I was planning that as part of another run of coverage improvements but I'm behind with performance work too.

@akarnokd akarnokd merged commit 7791076 into ReactiveX:2.x Sep 23, 2016
@vanniktech vanniktech deleted the 2.x_report_errors_to_plugin branch September 23, 2016 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants