2.x: Add error assertion with predicate to TestSubscriber and TestObserver #4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you do it for TestObserver as well? |
|
Sure. I will update the PR |
jraska
changed the title
Current coverage is 78.12% (diff: 100%)@@ 2.x #4586 diff @@
==========================================
Files 552 552
Lines 36184 36220 +36
Methods 0 0
Messages 0 0
Branches 5584 5594 +10
==========================================
+ Hits 28255 28296 +41
+ Misses 5917 5913 -4
+ Partials 2012 2011 -1
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for error assertions with to TestSubscriber requested in #4498 to support custom error evaluation. Removes the need to implement equals and hashCode in exceptions.