1.x: Deprecate Notification.createOnCompleted #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.26% (diff: 100%)@@ 1.x #4466 diff @@
==========================================
Files 271 271
Lines 17607 17607
Methods 0 0
Messages 0 0
Branches 2684 2684
==========================================
+ Hits 14823 14836 +13
+ Misses 1920 1918 -2
+ Partials 864 853 -11
|
| @@ -67,8 +67,10 @@ | |||
| * | |||
| * @param <T> the actual value type held by the Notification | |||
| * @param type | |||
| * @deprecated this method does the same as {@link #createOnCompleted()} and does not use the passed in type hence it's useless. | |||
There was a problem hiding this comment.
The argument allows for explicit type inference without needing to specify it on the method call directly when you already have a typed Class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4462
It might just as well shine some light into which method should be used and explain why there are 2