Implemented the 'Timeout' operator #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #365 FAILURE |
|
Let's evaluate this based on the previous submission and refactor towards simplicity while merging the good parts. I've pulled the other one in so we get the functionality (and 'SerialSubscription') and unit tests and now let's iterate on simplifying the concurrency behavior. |
|
@benjchristensen , Do you think which one is better? I can help merge these two PRs. |
|
@zsxwing I would prefer a simpler synchronization model as discussed here => #434 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I used
SynchronizedObserverto implement theTimeoutoperator #91. It may be simpler than #434. Considering DateTimeOffset and TimeSpan in C# have the same meaning, RxJava only needs 4 overrides. I have already implemented all of them.Please take a look. Thanks.