Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding collect method to Scala Observable #421

Closed
wants to merge 1 commit into from

Conversation

madnl
Copy link

@madnl madnl commented Oct 4, 2013

I think it's a good idea to add a collect method analogous with the one in the Scala collection library. It was simplest to implement it using a combination of filter & map.

If you find any major disadvantages with this please chime in.

@cloudbees-pull-request-builder

RxJava-pull-requests #329 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

@samuelgruetter can you review this and comment as it related to Scala?

@madnl thanks for getting involved. Once review with Samuel, can you please rebase this on top of the recent changes so it can merge without conflicts again? Right now it conflicts as there was a large set of Scala changes that just got merged to master.

@samuelgruetter
Copy link
Contributor

Yes, adding methods which are in Scala collections but not in RxJava is one of the points which are still on the TODO list.
@madnl your collect looks good, but we would also like to have some unit tests. (We had the following unit test policy for Scala adaptor until now: If a method just calls the corresponding RxJava method, no need for a test, but if new functionality is added, also add a test).

@benjchristensen
Copy link
Member

This conflicts so can't be cleanly merged. Can unit tests be added and a new pull request submitted after rebasing changes from master?

jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants