Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: lift into Subject #3975

Closed
wants to merge 1 commit into from
Closed

Conversation

akarnokd
Copy link
Member

See #2458.

This PR shows a way to implement lifting into a Subject. It is possible to lift on the front and the back side. The main idea is to add behavior to a Subject while presenting it to the outside world still as a Subject.

I'm not 100% certain the value of this because one has to write operators for this to work (relying on the rx.internal.operators is not recommended). The front-side operator can be simpler since it doesn't have to deal with unsubscription and backpressure as the wrapped Subjects don't have that capability on their front anyway.

@stevegury
Copy link
Member

I'm not convinced either by its value, do you have a example in mind?

@akarnokd
Copy link
Member Author

akarnokd commented Jun 2, 2016

This was @abersnaze 's long lasting dream from #2458. I thought I give an implementation to see if we want it or #2458 can be closed for good.

@abersnaze
Copy link
Contributor

I wouldn't go as far as saying it was a dream of my but it has always bugged me that the type Subject<T, R> clearly has an R that can be different but there isn't a practical way to change it. If subject is never intended to be used like that then we should change it to Subject<T> in 2.0.

@akarnokd akarnokd closed this Jun 14, 2016
@akarnokd akarnokd deleted the LiftIntoSubject branch June 28, 2016 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants