1.x: Add Single.onErrorResumeNext(Func) #3766
Conversation
| import rx.functions.Func1; | ||
| import rx.plugins.RxJavaPlugins; | ||
|
|
||
| public class SingleOperatorOnErrorResumeNext<T> implements Single.OnSubscribe<T> { |
There was a problem hiding this comment.
Just renamed SingleOperatorOnErrorResumeNextViaSingle to something more general and it's now works with function instead of Single directly.
artem-zinnatullin
force-pushed
the
single-on-error-resume-next-with-function
branch
from
a2f5e89 to
afd6649
Compare
|
|
||
| try { | ||
| unsubscribe(); | ||
| resumeFunctionInCaseOfError.call(error).subscribe(child); |
There was a problem hiding this comment.
I'd separate catching the error and subscribing to the Single outside the try-catch.
|
@akarnokd fixed your comments, btw, should I add |
| } | ||
|
|
||
| @Test | ||
| public void onErrorResumeNextViaFunctionShouldPreventNullFunction() { |
There was a problem hiding this comment.
Please also check/handle if the function returns a null Single.
There was a problem hiding this comment.
Added a test, but didn't handle this specifically in the operator, test will make sure that it won't be swallowed
|
Yes, and copy over the experimental and since tags into the javadoc. |
artem-zinnatullin
force-pushed
the
single-on-error-resume-next-with-function
branch
from
afd6649 to
0495044
Compare
|
👍 There is this new like option but do you get a notification for them? |
|
No On Mon, Mar 14, 2016, 8:10 PM David Karnok [email protected] wrote:
|
| @Override | ||
| public void onError(Throwable error) { | ||
| try { | ||
| resumeFunctionInCaseOfError.call(error).subscribe(child); |
There was a problem hiding this comment.
It's terminal state, we don't do unsubscribe() in onSuccess() too
There was a problem hiding this comment.
If resumeFunctionInCaseOfError returns something like Observable.never.toSingle, we should still unsubscribe the original one.
There was a problem hiding this comment.
Never mind. I just found SafeSubscriber will do it.
|
👍 |
|
👍 |
…e-next-with-function 1.x: Add Single.onErrorResumeNext(Func)
Closes #3440, closes #3731, closes #3472 (whoa, 3 issues at a time!)