1.x: unified onErrorX and onExceptionResumeNext and fixed backpressure #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a test failure in BackpressureTests.testMergeAsync, run before any of the changes of this PR and shouldn't have any effect. Overloaded servers? |
| ts.assertNoErrors(); | ||
| ts.assertNotCompleted(); | ||
|
|
||
| ts.requestMore(2); |
There was a problem hiding this comment.
Not a big deal, but it should be requestMore(1) if you want to have the same behavior (than the other tests).
There was a problem hiding this comment.
It's deliberately overrequesting here.
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Feb 9, 2016
1.x: unified onErrorX and onExceptionResumeNext and fixed backpressure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operators didn't honor backpressure when they switched over to the other Observable.
This PR also includes the fix #3685.