Add combineLatest overload for Collection

[JakeWharton]

2.x already uses Iterable, but that's a very drastic change compared to just Collection.

Motivation here is that I'm using set bindings to create observables in a dependency injector and I want to skip the current new ArrayList<>(sources) that I have to do on the set.

[akarnokd]

Can we revisit this once #3507 is merged?

[JakeWharton]

Yep. That allows exposing Iterable as well which is even better.

[artem-zinnatullin]

final?

[artem-zinnatullin]

👍

Don't you want to add tests for your new Observable.combineLatest()? OnSubscribeCombineLatest.java is internal, will be great to cover public API as well for possible changes in future implementation and to test operator from user's point of view.

[JakeWharton]

The tests were modified to use it.

On Mon, Feb 1, 2016 at 10:27 AM Artem Zinnatullin [email protected]
wrote:

[image: 👍]

Don't you want to add tests for your new Observable.combineLatest()?
OnSubscribeCombineLatest.java is internal, will be great to cover public
API as well for possible changes in future implementation and to test
operator from user's point of view.

—
Reply to this email directly or view it on GitHub
#3660 (comment).

[artem-zinnatullin]

Tests for OnSubscribeCombineLatest were modified, but I'm talking about tests for Observable.combineLatest(Collection, FuncN).

[JakeWharton]

They use that API.