fix error handling in onBackpressureBuffer #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| } catch (Throwable e) { | ||
| Exceptions.throwIfFatal(e); | ||
| manager.terminateAndDrain(e); | ||
| // this line not strictly necessary but nice for clarity |
|
👍 |
| try { | ||
| onOverflow.call(); | ||
| } catch (Throwable e) { | ||
| Exceptions.throwIfFatal(e); |
There was a problem hiding this comment.
Need to notify the plugin instead of swallowing the non fatal exceptions.
There was a problem hiding this comment.
It does not swallow it but emits via L164 to the child subscriber.
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Jan 25, 2016
…or-handling fix error handling in onBackpressureBuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onOverflow.call()was not wrapped in an appropriate try catch to prevent the error from being reported from an upstream operator.This PR includes a unit test that failed on the original code.