Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Observable#toCompletable #3567

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Implemented Observable#toCompletable #3567

merged 1 commit into from
Dec 9, 2015

Conversation

stealthcode
Copy link

No description provided.

@stealthcode
Copy link
Author

Addresses part of #3443

akarnokd
akarnokd reviewed Dec 9, 2015
View reviewed changes
src/main/java/rx/Observable.java
@@ -232,6 +232,26 @@ public void call(Subscriber<? super R> o) {
return new Single<T>(OnSubscribeSingle.create(this));
}

/**
* Returns a Completable that emits the single item emitted by the source Observable, if that Observable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no items involved with Completable.

@akarnokd
Copy link
Member

akarnokd commented Dec 9, 2015 

rx.internal.operators.OnSubscribeCompletableTest > testShouldUseUnsafeSubscribeInternallyNotSubscribe FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:92)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.junit.Assert.assertFalse(Assert.java:68)
        at org.junit.Assert.assertFalse(Assert.java:79)
        at rx.internal.operators.OnSubscribeCompletableTest.testShouldUseUnsafeSubscribeInternallyNotSubscribe(OnSubscribeCompletableTest.java:96)

The Completable.fromObservable needs to change to unsafeSubscribe.

@DavidMGross DavidMGross mentioned this pull request Dec 9, 2015
Open
@stealthcode
Copy link
Author

Thanks @akarnokd

@akarnokd
Copy link
Member

akarnokd commented Dec 9, 2015

👍

akarnokd added a commit that referenced this pull request Dec 9, 2015
@akarnokd
Merge pull request #3567 from stealthcode/ToCompletable
0c039ee 
Implemented Observable#toCompletable
@akarnokd akarnokd merged commit 0c039ee into ReactiveX:1.x Dec 9, 2015
@stevegury
Copy link
Member

👍

@abersnaze abersnaze mentioned this pull request Dec 14, 2015
Closed
@akarnokd akarnokd mentioned this pull request Feb 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stealthcode @akarnokd @stevegury