1.x: add shorter RxJavaPlugin class lookup approach.

[akarnokd]

This adds a new pattern and lookup method that let's the developer specify the custom plugins with shorter system property keys. Android is quite restrictive and allows only 31 characters.

The new pattern splits the target simple class name and its implementation into two separate system properties:

rxjava.plugin.1.class=SimpleClassName
rxjava.plugin.1.impl=path.to.impl.Class

The index tag (1) can be any string of your chosing:

rxjava.plugin.mykey.class=SimpleClassName
rxjava.plugin.mykey.impl=path.to.impl.Class

but make sure they are paired, otherwise nothing will happen.

If there are multiple class entries with the same SimpleClassName one of them will be chosen (depending on the walk order in java.util.Properties).

Related issue #2835.

[stealthcode]

👍

[artem-zinnatullin]

Can you change test to VisibleForTesting? It's pretty common pattern.

[akarnokd]

I couldn't find this VisibleForTesting in RxJava.

[zsxwing]

VisibleForTesting is in Guava

[artem-zinnatullin]

I meant not annotation but comment.

On Wed, Nov 11, 2015, 21:32 Shixiong Zhu [email protected] wrote:

In src/main/java/rx/plugins/RxJavaPlugins.java
#3513 (comment):

@@ -141,7 +156,7 @@ public void registerObservableExecutionHook(RxJavaObservableExecutionHook impl)
}
}

• private static Object getPluginImplementationViaProperty(Class<?> pluginClass) {
• /* test */ static Object getPluginImplementationViaProperty(Class<?> pluginClass, Properties props) {

VisibleForTesting is in Guava

—
Reply to this email directly or view it on GitHub
https://github.com/ReactiveX/RxJava/pull/3513/files#r44567271.

@artem_zin

[akarnokd]

Updated: made strings local constants and using length˙instead of magic numbers. Plus, if the default keying matches, the properties is not traversed for an alternate specification.

[akarnokd]

An alternative pattern could be this:

rxjava.plugin.1=SimpleClassName,org.package.naming.ActualClass

[stealthcode]

I agree that if the plugin cannot be found we should crash the app.

[akarnokd]

Updated the code to crash if the plugin implementation is missing.

[stealthcode]

Thanks!