Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: Completable class to support valueless event composition + tests #3444

Merged
merged 1 commit into from
Dec 7, 2015

Conversation

akarnokd
Copy link
Member

This is a backport of #3439.

@stealthcode
Copy link

Looks good. Should we annotate @Experimental on all the public methods and operators?

@akarnokd
Copy link
Member Author

akarnokd commented Dec 5, 2015

Now, the class annotation should indicate all methods are experimental. If individual methods get promoted, we can add direct annotations then.

@stealthcode
Copy link

Sounds good 👍

On Sat, Dec 5, 2015, 01:38 David Karnok [email protected] wrote:

Now, the class annotation should indicate all methods are experimental. If
individual methods get promoted, we can add direct annotations then.


Reply to this email directly or view it on GitHub
#3444 (comment).

@akarnokd
Copy link
Member Author

akarnokd commented Dec 5, 2015

Since this adds to the API surface, I'd like to get another like before merging.

@stevegury
Copy link
Member

👍

akarnokd added a commit that referenced this pull request Dec 7, 2015
1.x: Completable class to support valueless event composition + tests
@akarnokd akarnokd merged commit 8316519 into ReactiveX:1.x Dec 7, 2015
@akarnokd akarnokd deleted the Completable1x branch December 7, 2015 22:59
@stealthcode
Copy link

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants