Improve Subscriber readability #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjchristensen
added a commit
that referenced
this pull request
Jun 9, 2015
Improve Subscriber readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Subscriberclass is something I encounter frequently when debug stepping through code and is hard to read. This PR improves the names of variables and makes therequestmethod more readable in particular by moving some code off into another method.I've also put in a
returnstraight after theaddToRequested(n)call so that we don't need to make an unnecessary test ofproducerToRequestFrom != null. Very minor saving I'm sure but why not.Javadoc is still missing and I thought to leave that for another PR (because it will require a bit more thought).