Prevent ExceptionsTest from hanging when testing stack overflow #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks! |
akarnokd
added a commit
that referenced
this pull request
Apr 21, 2015
Prevent ExceptionsTest from hanging when testing stack overflow
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my i5 laptop
ExceptionsTest.testStackOverflowIsThrowhangs. This PR changes the test so that it confirms that significant stack depth occurs and in another test ensures that the fatalStackOverflowErroris thrown bysubscribewhen it occurs inonNext.I also removed some unused code from the original test and some extra subscriptions that didn't seem to serve a particular function.