issue-2764: add new operator onBackpressureDrop(Action1 onDrop) #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return the source Observable modified to drop {@code onNext} notifications on overflow | ||
| * @see <a href="http://reactivex.io/documentation/operators/backpressure.html">ReactiveX operators documentation: backpressure operators</a> | ||
| */ | ||
| public final Observable<T> onBackpressureDrop(Action1 onDrop) { |
There was a problem hiding this comment.
Action1 should be generic: Action1<? super T> onDrop
There was a problem hiding this comment.
will fix. forgot the generic for arg. did it for member var.
stevenzwu
force-pushed
the
issues-2764
branch
from
2a8e7da to
b99492d
Compare
| * @return the source Observable modified to drop {@code onNext} notifications on overflow | ||
| * @see <a href="http://reactivex.io/documentation/operators/backpressure.html">ReactiveX operators documentation: backpressure operators</a> | ||
| */ | ||
| public final Observable<T> onBackpressureDrop(Action1<T> onDrop) { |
There was a problem hiding this comment.
You need Action1<? super T> here.
|
added super to generic type T |
| * @return the source Observable modified to drop {@code onNext} notifications on overflow | ||
| * @see <a href="http://reactivex.io/documentation/operators/backpressure.html">ReactiveX operators documentation: backpressure operators</a> | ||
| */ | ||
| public final Observable<T> onBackpressureDrop(Action1<? super T> onDrop) { |
There was a problem hiding this comment.
Please add @Experimental annotation to this method.
|
I will manually add Experimental to it after merging. |
benjchristensen
added a commit
that referenced
this pull request
Mar 4, 2015
issue-2764: add new operator onBackpressureDrop(Action1 onDrop)
|
Thanks @stevenzwu |
|
thanks. looks like I missed a lot of details :) |
This was referenced Mar 5, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.