Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatMap overloads with maximum concurrency parameter #2627

Merged
merged 1 commit into from
Feb 11, 2015

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Feb 6, 2015

For issue #2626.

There is no point in adding maxConcurrent to flatMapIterable because each iterable is subscribed to sequentially and run to completion.

@benjchristensen
Copy link
Member

👍

benjchristensen added a commit that referenced this pull request Feb 11, 2015
FlatMap overloads with maximum concurrency parameter
@benjchristensen benjchristensen merged commit 13001d0 into ReactiveX:1.x Feb 11, 2015
@akarnokd akarnokd deleted the FlatMapMaxConcurrent branch March 11, 2015 13:49
@akarnokd
Copy link
Member Author

There is no point in adding maxConcurrent to flatMapIterable because each iterable is subscribed to sequentially and run to completion.

I was wrong with this statement. Depending on the request pattern, reordering may still happen and the downstream may be still slower. Unboundedness of flatMapIterable may still cause excessive source Iterable generation that fills in the tracking arrays inside flatMap.

Having the maxConcurrency parameter is valuable and prevents buffer bloat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants