Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multicast: Observable.publish() #261

Closed
wants to merge 2 commits into from

Conversation

jmhofer
Copy link
Contributor

@jmhofer jmhofer commented May 7, 2013

A very little API addition: publishing observables without requiring a Subject. See #65 (and http://northhorizon.net/2011/sharing-in-rx/).

@benjchristensen
Copy link
Member

I happened to implement this last night as well as replay and cache in #260

@cloudbees-pull-request-builder

RxJava-pull-requests #132 SUCCESS
This pull request looks good

@jmhofer
Copy link
Contributor Author

jmhofer commented May 7, 2013

Oh, haha, funny, then this pull request is superfluous.

@benjchristensen
Copy link
Member

Could you take a quick look at the other pull request to confirm correctness of the 3 operators? I added a unit test for each of them as well.

@jmhofer
Copy link
Contributor Author

jmhofer commented May 7, 2013

As far as I can see, this looks good.

@benjchristensen
Copy link
Member

Thanks @jmhofer

@jmhofer jmhofer deleted the multicast-publish branch May 7, 2013 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants