Created the initial implementation of BehaviorSubject #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #119 SUCCESS |
|
I agree it's obnoxious that the If anyone else has other ideas on how to deal with this please suggest them otherwise I think the |
| import rx.util.functions.Func1; | ||
|
|
||
| /** | ||
| * Subject that publishes the previous and all subsequent events to each {@link Observer} that subscribes. |
There was a problem hiding this comment.
Perhaps replacing "previous" with "last" is clearer that this is not all previous events but only the most recent (last) event?
|
RxJava-pull-requests #127 FAILURE |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
- We don't need to add synchronization as the subjects can trust their source Observables to comply with the Rx contract. - This optimization follows Rx Design Guidelines 6.8. Avoid serializing operators This was discussed at ReactiveX#256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to implement the BehaviorSubject. Functionally it works as it should, but I'm not entirely happy with the static
createWithDefaultValue(T)method. I can't create a static methodcreate(T)because Subject extends Observable, which has a staticcreate(Object)method. So to resolve that I had to give the static method in BehaviorSubject a different name.Additionally I'm using an
AtomicReference<T>in this static method to keep track of the last published value. I tried coming up with different solutions to push the last published value to the Observer when it's subscribing, but this seems to be the most clean solution.If there's any feedback on either issue, please let me know.