Scheduling actions periodically #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 12, 2013 13:48
…eactiveX#228, needs some testing next...
…y a too little amount
…ulePeriodically to use now() instead of System.nanoTime() and added a test against scheduling periodically
|
RxJava-pull-requests #106 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
May 1, 2013
Scheduling actions periodically
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Scheduling actions periodically
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
make async retrofit call not make the request when circuit is open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed earlier by @mairbek in #228 (comment), I extended the
Schedulerby yet another methodschedulePeriodically. This has a default implementation that works via recursion. I tried it out with all existing schedulers, and it seems to work fine. I also wrote a unit test for it using theTestScheduler.I switched scheduled executor services to use their fixed rate scheduling instead of the recursive default implementation. And I also switched the
OperationIntervalimplementation to use periodic scheduling.